----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38588/#review99989 -----------------------------------------------------------
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java (lines 98 - 106) <https://reviews.apache.org/r/38588/#comment157053> Thinking out-lound here - would it make sense for teste purpose to use the usual "startServer()" method just started in separate thread? I'm thinking about that as I'm concerned that we will eventually diverge in implementation between startServer() and startServerForTest() so I'm thinking if we can somehow use exactly the same code base. server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java (lines 126 - 129) <https://reviews.apache.org/r/38588/#comment157052> Do we need this main? - Jarek Cecho On Sept. 22, 2015, 1:25 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38588/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 1:25 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Create new class for Jetty server > > > Diffs > ----- > > server/src/main/java/org/apache/sqoop/server/SqoopJettyConstants.java > PRE-CREATION > server/src/main/java/org/apache/sqoop/server/SqoopJettyContext.java > PRE-CREATION > server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/38588/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
