----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38554/#review100840 -----------------------------------------------------------
The patch looks good to me, my only comment is that we should document behavior of CLOB for Avro in the user documentation (mainly differences with text file and fact that --inline-lob-limit will get ignored in such case): http://sqoop.apache.org/docs/1.4.6/SqoopUserGuide.html#_large_objects - Jarek Cecho On Sept. 21, 2015, 12:19 p.m., Nick White wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38554/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 12:19 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Repository: sqoop-trunk > > > Description > ------- > > Adds CLOB & ROWID support to Sqoop. > > > Diffs > ----- > > src/java/org/apache/sqoop/avro/AvroUtil.java 9036076 > src/java/org/apache/sqoop/manager/ConnManager.java d9569c5 > src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 0ea5ca4 > src/java/org/apache/sqoop/mapreduce/MergeAvroReducer.java 2e85f51 > src/java/org/apache/sqoop/mapreduce/ParquetImportMapper.java 45211fc > src/test/org/apache/sqoop/TestImportAvro.java PRE-CREATION > > Diff: https://reviews.apache.org/r/38554/diff/ > > > Testing > ------- > > Unit tests included in patch > > > Thanks, > > Nick White > >
