----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39030/#review101728 -----------------------------------------------------------
Ship it! +1 as long as precommit hook passes - Jarek Cecho On Oct. 7, 2015, 12:05 a.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39030/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 12:05 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2490 > https://issues.apache.org/jira/browse/SQOOP-2490 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Sqoop2: Add extra jars to job > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java > d7fe27b > core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 52e432d > core/src/main/java/org/apache/sqoop/driver/JobManager.java ebb7efd > core/src/main/java/org/apache/sqoop/driver/configuration/JarConfig.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java > bf1328a > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java f9649f2 > core/src/main/resources/driver-config.properties e005775 > core/src/test/java/org/apache/sqoop/driver/TestJobConfiguration.java > PRE-CREATION > dist/src/main/server/conf/sqoop.properties fe8bcce > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 7440025 > > test/src/test/java/org/apache/sqoop/integration/classpath/ClasspathTest.java > PRE-CREATION > test/src/test/resources/TestConnector/TestConnector.java PRE-CREATION > test/src/test/resources/TestConnector/TestDependency.java PRE-CREATION > test/src/test/resources/TestConnector/TestLinkConfiguration.java > PRE-CREATION > test/src/test/resources/TestConnector/TestLoader.java PRE-CREATION > test/src/test/resources/TestConnector/TestToDestroyer.java PRE-CREATION > test/src/test/resources/TestConnector/TestToInitializer.java PRE-CREATION > test/src/test/resources/TestConnector/TestToJobConfiguration.java > PRE-CREATION > test/src/test/resources/TestConnector/sqoopconnector.properties > PRE-CREATION > test/src/test/resources/classpath-tests-suite.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/39030/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Abraham Fine > >
