----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39198/#review102558 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Oct. 13, 2015, 8:01 p.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39198/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 8:01 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1442 > https://issues.apache.org/jira/browse/SQOOP-1442 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > [WIP] Sqoop2: Validations: Serialize validations over the wire for client > transfer > > > Diffs > ----- > > client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java ed0badc > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 0322032 > common/src/main/java/org/apache/sqoop/json/DriverBean.java 6012917 > common/src/main/java/org/apache/sqoop/json/JobBean.java e983075 > common/src/main/java/org/apache/sqoop/json/LinkBean.java 2e2406f > common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java > b301563 > > common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java > 03e869c > > common/src/main/java/org/apache/sqoop/json/util/ConfigValidatorConstants.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 493de8d > common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 1b350f7 > common/src/main/java/org/apache/sqoop/model/MBooleanInput.java d55a0e7 > common/src/main/java/org/apache/sqoop/model/MConfig.java ad04263 > common/src/main/java/org/apache/sqoop/model/MConfigList.java 1d889ea > common/src/main/java/org/apache/sqoop/model/MDateTimeInput.java 7ce2558 > common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 77d947f > common/src/main/java/org/apache/sqoop/model/MEnumInput.java df702f8 > common/src/main/java/org/apache/sqoop/model/MFromConfig.java 7093a93 > common/src/main/java/org/apache/sqoop/model/MInput.java 649f2fd > common/src/main/java/org/apache/sqoop/model/MIntegerInput.java 90b2d95 > common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 6b33fdc > common/src/main/java/org/apache/sqoop/model/MListInput.java 04dbaf2 > common/src/main/java/org/apache/sqoop/model/MLongInput.java eb2c277 > common/src/main/java/org/apache/sqoop/model/MMapInput.java 4e8df34 > common/src/main/java/org/apache/sqoop/model/MNamedElement.java 7972467 > common/src/main/java/org/apache/sqoop/model/MStringInput.java 7365098 > common/src/main/java/org/apache/sqoop/model/MToConfig.java eff533f > common/src/main/java/org/apache/sqoop/model/MValidatedElement.java c8042f6 > common/src/main/java/org/apache/sqoop/model/MValidator.java PRE-CREATION > common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 59d900f > common/src/test/java/org/apache/sqoop/json/TestLinksBean.java 7faab88 > common/src/test/java/org/apache/sqoop/json/util/BeanTestUtil.java ba69de6 > common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java fbc7faa > > common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java > b188c4c > common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 9ee0eec > common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java > 4113b50 > common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java d659c9e > common/src/test/java/org/apache/sqoop/model/TestMConfig.java 00b4a46 > common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 0d2ff61 > common/src/test/java/org/apache/sqoop/model/TestMConnector.java d996692 > common/src/test/java/org/apache/sqoop/model/TestMDateTimeInput.java 9c110cd > common/src/test/java/org/apache/sqoop/model/TestMDriver.java f947a60 > common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 6f588ef > common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java aa5bdef > common/src/test/java/org/apache/sqoop/model/TestMJob.java 6867ead > common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java bc69c6c > common/src/test/java/org/apache/sqoop/model/TestMLink.java f22719f > common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java 7056f49 > common/src/test/java/org/apache/sqoop/model/TestMListInput.java decf927 > common/src/test/java/org/apache/sqoop/model/TestMMapInput.java 6c2b7e6 > common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java c523d65 > common/src/test/java/org/apache/sqoop/model/TestMStringInput.java 37a04c2 > common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java > 4bd218e > common/src/test/java/org/apache/sqoop/model/TestMValidator.java > PRE-CREATION > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java > e05b93d > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteConnectorUpgrader.java > a6943f4 > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 4df7782 > core/src/main/java/org/apache/sqoop/driver/Driver.java cff2bef > core/src/main/java/org/apache/sqoop/repository/Repository.java cc29e39 > core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java > 84020d6 > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > 1d630a9 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > 79b9e99 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > ed176fe > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java > 44f968a > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java > faa0399 > shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java 2dbde97 > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java > 244683d > > Diff: https://reviews.apache.org/r/39198/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Abraham Fine > >
