----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39512/#review103846 -----------------------------------------------------------
Thanks for the clean up Colin! I have one final question: repository/repository-mysql/pom.xml (lines 83 - 85) <https://reviews.apache.org/r/39512/#comment161941> It seems as copy&past of the defaults defined in MySQLProvider - any reason for repeating them here in the pom file? Jarcec - Jarek Cecho On Oct. 23, 2015, 6:20 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39512/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 6:20 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > The unit test for MySql repository should be enable when do the pre-commit. > Add embed MySql server with mysql-connector-mxj. > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > cef59bb > repository/repository-mysql/pom.xml 15e909e > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java > fcd4b71 > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestConnectorHandling.java > 4d30b5e > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestDriverHandling.java > c3144ef > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestHandler.java > bfa53bd > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestJobHandling.java > 4784f10 > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestLinkHandling.java > 2e33cdb > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestSubmissionHandling.java > faf01cb > > Diff: https://reviews.apache.org/r/39512/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
