----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39573/#review103851 -----------------------------------------------------------
Thanks for incorporating my comments! connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java (line 68) <https://reviews.apache.org/r/39573/#comment161949> Can we remove the unnecesary "+" ? :) connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java (line 74) <https://reviews.apache.org/r/39573/#comment161950> Can we remove the unnecesary "+" ? :) execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java (lines 77 - 78) <https://reviews.apache.org/r/39573/#comment161952> The "JobContext" here is again the "wrong" context, right? execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java (line 264) <https://reviews.apache.org/r/39573/#comment161953> The "JobContext" here is again the "wrong" context, right? server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java (line 97) <https://reviews.apache.org/r/39573/#comment161954> Wondereing why this change? Did we had a bug in the code before? test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java <https://reviews.apache.org/r/39573/#comment161956> Nit: Seems as not-relevant change. Jarcec - Jarek Cecho On Oct. 23, 2015, 7:11 p.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39573/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 7:11 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1690 > https://issues.apache.org/jira/browse/SQOOP-1690 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > doAs for sqoop2 > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/job/etl/DestroyerContext.java > f4f6d1d35afc943208c50c371d1bc879e822c44c > common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java > 43fcaa227701331ab16e7ec941e749e8800e3b93 > common/src/main/java/org/apache/sqoop/job/etl/InitializerContext.java > 469132b30285d11bdb08ed2288e4916854b40d04 > common/src/main/java/org/apache/sqoop/job/etl/LoaderContext.java > f9ea9ad5906c8a5b7445584d03fcb67239abbf47 > common/src/main/java/org/apache/sqoop/job/etl/PartitionerContext.java > bb52bb249f80b278570a1c51984426fec97446a0 > > connector/connector-ftp/src/test/java/org/apache/sqoop/connector/ftp/TestFtpLoader.java > 33c808ad44c30280fa8249fa0bf0d44707972548 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java > 264cadf01da5896d5db4616bde35624fac1fac14 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java > ab319323889c77e77ac7735e66ea806669912fa5 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java > 83411fbd5434d99becfb747c2401ff37218fdcb8 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java > bec64789f0b5374b869a9d675a0b82db06ae3723 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java > df405c8e7395ca4c8bc63808878433c4f8abc07f > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java > 23bbcc0c9f954274d0d331f44d54f16287bbe065 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java > e98e02b7902260532796a2a40d689486c7d0f634 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java > 798e5522b890557661eaddd583fb18a264cc47ad > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java > ff16ad79da2b4102988ca414ff792c715f3845a6 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToDestroyer.java > 11b2ae3618d1c8d85c074aa38ca6429e5aa2913a > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java > 29cf3b98d8210221501c98e4d3ef762c68c2b868 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java > 6f9986dcc9be1b705a2470b2ff39b795212f5555 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestFromDestroyer.java > 569c60bb8c9ac62c8355a44619ec1273718c1323 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestFromInitializer.java > 52c174ed6bdffac90abcb571b39b6f4f0c3f7b3c > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java > ac44595d41ca823ace65d7d3fc14ed054a47c754 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java > 688067be7158ebb9bdc7ca24f92dc2e1dd2e97e8 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java > 9a6bfff144d07b1b4bb7487282a1153bda8d50e1 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToDestroyer.java > e1f416e144fbc724e32774b9dd22b1c15d661c02 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java > a98a46a932e62512f288c55dc10c9310d3d48eed > > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestKafkaLoader.java > da2a7087b2cbc5901d79692448830ec21e6cbb02 > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExtractor.java > 08d2cb3eb8d7bd14cf442bf4a660d3c46c185a3c > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteLoader.java > 533b8c3f17b733a21da7c48c7f9885cc789a385a > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToDestroyer.java > 3fcc339255a9ba1dc214b3150397200e50d6cff2 > core/src/main/java/org/apache/sqoop/driver/JobManager.java > 0d230f970ecf28451313655bfadcb99bf5454209 > > execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java > c8d210eacb22946568403a3a3b658838bed7fcae > execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java > b7aa8c6832b38a42e45ccde9882cce616fbcf1e1 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java > b3c1ce84ad13b0b7ab9690c9bb10b2a8a9ddf236 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java > 67189a1f00806f8fa09029c909a2edce8fa32f95 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > c93813bdd68d7ead07863673f9089be9a8ce20ce > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java > 88ab98e4f32f1c923d529540e9fa6bf3334de6e3 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > d94b658a363bfdb4ef208e043db8f2733135ea00 > server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java > ddca9d4e979abd81d99d272d4e8ed02394d75b29 > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 8a0faf87336a687d04c30202002b694bffd7b06e > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java > 9b77d9838efa3ccc9ef49c9652cabb80e4351053 > > Diff: https://reviews.apache.org/r/39573/diff/ > > > Testing > ------- > > > Thanks, > > Abraham Fine > >
