----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39643/#review104135 -----------------------------------------------------------
Thanks for working on this. Please see the following comments src/docs/user/connectors.txt (line 530) <https://reviews.apache.org/r/39643/#comment162390> Did you mean MySql or Teradata? Is it a typo? src/java/com/cloudera/sqoop/manager/TeradataJdbcManager.java (line 28) <https://reviews.apache.org/r/39643/#comment162391> No need for this file. We should be using org.apache.sqoop for all new managers and connectors src/test/com/cloudera/sqoop/manager/TestUpsertInTeradataJdbcManager.java (line 41) <https://reviews.apache.org/r/39643/#comment162392> Tests that start with the prefix "Test" are part of the unit tests and should not need any infrastructure like Teradata DB. Can you follow the example for other tests that use third party DB src/test/org/apache/sqoop/mapreduce/TeradataUpsertOutputFormatTest.java (line 19) <https://reviews.apache.org/r/39643/#comment162393> method name should not start with Uppercase letter. Use camelcase to be consistent with rest of the codebase - Venkat Ranganathan On Oct. 26, 2015, 12:45 a.m., kopal niranjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39643/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 12:45 a.m.) > > > Review request for Sqoop and Venkat Ranganathan. > > > Repository: sqoop-trunk > > > Description > ------- > > Sqoop export fails when we perform upserts from HDFS to Teradta > > sqoop export --driver com.teradata.jdbc.TeraDriver --connect > jdbc:teradata://10.127.54.34/DATABASE=user_db,TMODE=ANSI,LOGMECH=LDAP > --username abc -P --table upsert_tbl --export-dir /user/root/exportRec/ > --update-key id --update-mode allowinsert > > Above command fails with the following error: > > 15/10/16 02:51:19 ERROR tool.ExportTool: Error during export: Mixed > update/insert is not supported against the target database yet > > > Diffs > ----- > > src/docs/user/connectors.txt c5ce4d6 > src/java/com/cloudera/sqoop/manager/TeradataJdbcManager.java PRE-CREATION > src/java/org/apache/sqoop/manager/TeradataJdbcManager.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/TeradataUpsertOutputFormat.java > PRE-CREATION > src/test/com/cloudera/sqoop/manager/TestUpsertInTeradataJdbcManager.java > PRE-CREATION > src/test/org/apache/sqoop/mapreduce/TeradataUpsertOutputFormatTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39643/diff/ > > > Testing > ------- > > yes > > > Thanks, > > kopal niranjan > >
