----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39260/#review104140 -----------------------------------------------------------
src/docs/user/hcatalog.txt (line 115) <https://reviews.apache.org/r/39260/#comment162408> I think we have to change the description a bit - currently it gives the impression that dynamic partitions are not supported. Can we say something alone the lines of: This has the list of column to be added as partitioning keys to the created table along with the static partitioning keys and values provided. For dynamic partitions keys, the data type of the partition key will be forced to be string irrespective of the SQL datatype src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 610) <https://reviews.apache.org/r/39260/#comment162410> Please add a space after the '.' src/test/org/apache/sqoop/hcat/HCatalogImportTest.java (line 277) <https://reviews.apache.org/r/39260/#comment162409> Better to print a log message - Venkat Ranganathan On Oct. 13, 2015, 2:42 a.m., Shashank Tandon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39260/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 2:42 a.m.) > > > Review request for Sqoop and Venkat Ranganathan. > > > Repository: sqoop-trunk > > > Description > ------- > > New Review request for support of Dynamic partitons while importing data. > This is in addition to the old review https://reviews.apache.org/r/38400/ > already exists, but in the review board submitter cannot be changed so adding > another review request to add a new patch for the code review changes. > Functioanlity : Dynamic partition already exists in Sqoop in case of Hive > partitioned table already exists.The new changes will allow to support > dynamic partition if Hive partitioned table does not exists. > Users can just tell the list of columns based on which partitioning should > happen. Also support for date formats is added if user wants to do > partitioning based on a date column. > > > Diffs > ----- > > src/docs/user/hcatalog.txt 99ae4f5 > src/java/org/apache/sqoop/SqoopOptions.java db92b30 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java aba2458 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 9d5a9ee > src/java/org/apache/sqoop/tool/BaseSqoopTool.java a7f6aec > src/java/org/apache/sqoop/tool/ImportTool.java 39af42c > src/test/org/apache/sqoop/hcat/HCatalogImportTest.java 8db06d1 > > Diff: https://reviews.apache.org/r/39260/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Shashank Tandon > >
