----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39668/#review104179 -----------------------------------------------------------
Ship it! Looks good, I have few nits: dist/src/main/conf/sqoop.properties (lines 203 - 204) <https://reviews.apache.org/r/39668/#comment162471> Can we put comment helping our user figure out what is the format. For example: # Comma separated list of blacklisted connectors #org.apache.sqoop.connector.blacklist=generic-jdbc-connector,kafka-connector org.apache.sqoop.connector.blacklist= test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java (line 65) <https://reviews.apache.org/r/39668/#comment162472> I'm expecting that the "saveLink" is not even required here right? Even the "createLink" call should have failed, right? Jarcec - Jarek Cecho On Oct. 26, 2015, 8:52 p.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39668/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 8:52 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2629 > https://issues.apache.org/jira/browse/SQOOP-2629 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Sqoop2: Add ability to "blacklist" connectors > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java > 285e893805b3f172bde75eaf8f5875a5cd9e1251 > core/src/main/java/org/apache/sqoop/connector/ConnectorManagerUtils.java > 522ed08337082e551689d907658173cfcb6af92a > core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java > f49fca39956a9aef3172da74d1abe42c8f42a3e6 > > core/src/test/java/org/apache/sqoop/connector/TestConnectorManagerUtils.java > fd2d1b457ae296c26f5d1b50829dd6474a430435 > core/src/test/java/org/apache/sqoop/driver/TestJobManager.java > 2d7dfeff5379cf48a8ad84f2d5526ec7bf385e64 > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > bb4da656c8a18c8fb7a7b98f48b69f2c2d57616e > dist/src/main/conf/sqoop.properties > 7c1ec183518069381800c86051f69294d4fa2056 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 030215000e3ff8bd2076e56b090772973349cbb6 > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 8a0faf87336a687d04c30202002b694bffd7b06e > > test/src/test/java/org/apache/sqoop/integration/classpath/ClasspathTest.java > 393b8003b9f3e4b30dfeb04f6818e82d78559453 > > test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java > PRE-CREATION > test/src/test/resources/classpath-tests-suite.xml > e5a9e94513762958adaf19eba032bd8a8444075b > > Diff: https://reviews.apache.org/r/39668/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Abraham Fine > >
