----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38881/#review105264 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Nov. 5, 2015, 3:09 a.m., David Robson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38881/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 3:09 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2595 > https://issues.apache.org/jira/browse/SQOOP-2595 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Have migrated the code from the Oracle direct connector to Sqoop 2. There is > still work to be done but it is working so I would like to get some feedback > on the work so far. As the code is limited to one connector I am hoping we > can commit it then fix issues in follow up JIRAs as it will make it a bit > easier to break the tasks down. > > > Diffs > ----- > > connector/connector-oracle-jdbc/pom.xml PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcCommonInitializer.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcConnector.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcConnectorConstants.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcConnectorUpgrader.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcExtractor.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcFromDestroyer.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcFromInitializer.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcLoader.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcPartition.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcPartitioner.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcToDestroyer.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcToInitializer.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/ConnectionConfig.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/FromJobConfig.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/FromJobConfiguration.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/LinkConfiguration.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/ToJobConfig.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/ToJobConfiguration.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleActiveInstance.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleConnectionFactory.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleDataChunk.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleDataChunkExtent.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleDataChunkPartition.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleGenerics.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleJdbcUrl.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleQueries.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleSqlTypesUtils.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleTable.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleTableColumn.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleTableColumns.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleTablePartition.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleTablePartitions.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleUtilities.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleVersion.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/resources/oracle-jdbc-connector-config.properties > PRE-CREATION > > connector/connector-oracle-jdbc/src/main/resources/sqoopconnector.properties > PRE-CREATION > > connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/TestOracleJdbcPartitioner.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/TestOracleJdbcUrl.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/TestOracleTable.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/TestOracleUtilities.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/integration/OracleConnectionFactoryTest.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/integration/OracleQueriesTest.java > PRE-CREATION > > connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/integration/OracleTestCase.java > PRE-CREATION > connector/pom.xml 1b69180 > pom.xml ab505f4 > server/pom.xml ca068e0 > > Diff: https://reviews.apache.org/r/38881/diff/ > > > Testing > ------- > > Have done lots of manual testing and migrated some of the automated tests. > Some of them I am having issues with which I will follow up. > > > Thanks, > > David Robson > >
