> On Nov. 8, 2015, 7:52 a.m., Abraham Elmahrek wrote: > > Good stuff... just two thoughts...
Thanks for the review Abe! I would prefer not to mess with HTTP return codes as part of this JIRA. We're using one simple HTTP code for all exceptions that are being sent back from server and we're using HTTP code 500 for that. We can look into sending various other codes, but that seems orthogonal to this JIRA. Would you agree? - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40049/#review105605 ----------------------------------------------------------- On Nov. 7, 2015, 11:25 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40049/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2015, 11:25 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2670 > https://issues.apache.org/jira/browse/SQOOP-2670 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've refactored the method responsible for retrieving links as described on > the JIRA. > > > Diffs > ----- > > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > fe0c4d8 > server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 3fb542f > > test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java > 856d21f > > Diff: https://reviews.apache.org/r/40049/diff/ > > > Testing > ------- > > I've added bunch of test cases to REST test verifying that we're behaving as > expected. > > > Thanks, > > Jarek Cecho > >
