[ 
https://issues.apache.org/jira/browse/SQOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997494#comment-14997494
 ] 

Hari Shreedharan commented on SQOOP-2659:
-----------------------------------------

+1 committing. 

> Sqoop2: Do not stop services that haven't been started in our integration 
> test suite
> ------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2659
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2659
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.6
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2659.patch, SQOOP-2659.patch
>
>
> While investigating pre-commit hook failures on SQOOP-2652  I was side 
> tracked at a lot by seeing various exceptions from Hive and Kafka test cases 
> with {{NullPointerException}} and spending time investigating them.
> Upon further investigation I've noticed that the whole reason is that we're 
> shutting down something that wasn't started and hence the NPE. The problem 
> was that my newly added test case had added an {{assume}} statement in 
> {{@Before*}} family of methods. The {{assume}} statement return false and 
> stopped test execution before the Hive/Kite test cases got initialized. 
> However the testng will execute all  tear down methods ({{@After*}} and not 
> only those that have been initialized. Hence the tear down methods must be 
> smart enough to not die if the initialization in fact did not happened.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to