Github user gabrielreid commented on the pull request:
https://github.com/apache/sqoop/pull/10#issuecomment-155878871
Just taking a look through this -- having Phoenix support in Sqoop would be
great!
I know that this is an initial cut, but just a few remarks on the code:
* Around code style:
* it looks like the general Sqoop convention is to use 2 spaces for
indentation, but this code uses 4 spaces
* the Sqoop code includes a space after an `if` and before the opening
parenthesis, but this code omits that space
* The `PhoenixImportJob` class extends the `DataDrivenImportJob` class in
the `com.cloudera.sqoop` package, but this is deprecated -- I think that it
should probably extend the `DataDrivenImportJob` in the `org.apache.sqoop`
package. Same thing for the imports in that class.
I'll add a couple of other things I noticed as comments in the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
