Thanks for submitting patch Jonathan! It look good to me, so I went ahead and committed it :)
Jarcec > On Nov 12, 2015, at 12:40 PM, Jonathan Seidman <[email protected]> > wrote: > > Patch submitted. I just went ahead and removed the <build> element (mostly) > from the poms. The only side effect (other than eliminating the duplicate > jar names) is that the test jars are no longer generated. As far as I can > tell this doesn't impact anything, but if it does then it's easy enough to > put the <build> elements back in and modify to generate unique jar names. > > The exception is the Oracle connector pom – it's not clear to me if > removing the surefire plugin config impacts anything, so just removed the > <finalName> element to be on the safe side. > > I didn't create an RB, but let me know if one is necessary. > > Thanks > > On Wed, Nov 11, 2015 at 8:48 PM, Jonathan Seidman < > [email protected]> wrote: > >> Thanks Jarcec. I'll go ahead and prepare a patch. >> >>> On Nov 11, 2015, at 1:05 PM, Jarek Jarcec Cecho <[email protected]> >> wrote: >>> >>> Good work Jonathan! >>> >>> I’m failing to see what is the purpose of the whole build section in >> most of the pom files - perhaps we should just drop them all? I’m happy to >> review a patch if you have patch available :) >>> >>> >>> Jarcec >>> >>>> On Nov 11, 2015, at 12:29 PM, Jonathan Seidman < >> [email protected]> wrote: >>>> >>>> Hi Banmeet – I'm also seeing this issue, so I opened SQOOP-2681. This >>>> appears to be caused by the connector jars (except for the Kafka >> connector) >>>> getting created with identical file names (sqoop.jar), which then get >>>> copied to the server/lib directory. I'm assuming the last file copied to >>>> the server/lib directory is the one that gets picked up. Pending a more >>>> authoritative answer, I think a workaround that will allow continued >>>> test/dev is to update the connector poms to ensure unique names, for >>>> example in the pom for each connector change: >>>> >>>> <build> >>>> <finalName>sqoop</finalName> >>>> >>>> to: >>>> >>>> <build> >>>> <finalName>${artifactId}-${version}</finalName> >>>> >>>> The exception to this is the Kafka connector pom, which is missing the >>>> build element, which also accounts for the unique name for the jar. >>>> >>>> >>>> On Tue, Nov 10, 2015 at 9:58 PM, Banmeet Singh < >> [email protected]> >>>> wrote: >>>> >>>>> Just clarifying in case I was unclear in my last post :). I had tried >> mvn >>>>> clean package -Pbinary -DskipTests as well and still had the same >> problem. >>>>> >>>>> Thanks and regards >>>>> Banmeet Singh >>>>> Graduate Student >>>>> Department of Computer Science >>>>> Rutgers, The State University of New Jersey >>>>> Mob.: (732)-779-9741 >>>>> >>>>> On Tue, Nov 10, 2015 at 12:22 PM, Banmeet Singh < >>>>> [email protected]> >>>>> wrote: >>>>> >>>>>> Yes, sorry for missing this out. I've tried that as well. >>>>>>> On Nov 10, 2015 10:37 AM, "Jarek Jarcec Cecho" <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Can you try running: >>>>>>> >>>>>>> mvn *clean* package -Pbinary -DskipTests >>>>>>> >>>>>>> To force maven rebuild all files from scratch. >>>>>>> >>>>>>> Jarcec >>>>>>> >>>>>>>> On Nov 10, 2015, at 2:59 AM, Banmeet Singh < >>>>> [email protected]> >>>>>>> wrote: >>>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> I recently pulled upstream code into my local sqoop repo and checked >>>>>>> out the sqoop2 branch. I can see only two connectors (Kafka and >> SFTP) on >>>>>>> doing 'show connector' from the sqoop2-shell (screenshot attached). I >>>>> did >>>>>>> 'mvn package -Pbinary -DskipTests' for building the project and used >>>>>>> '.../sqoop2-server start' to start the sqoop2 server. I am currently >>>>>>> running the sqoop2 server and client on a single node (Ubuntu in a >>>>>>> VirtualBox VM/Ubuntu on an Amazon EC2 instance) with Hadoop (on >> YARN) in >>>>>>> pseudo distributed mode. The HEAD of my repo is currently at commit >> id >>>>>>> 82d9f02; SQOOP-2654 (screenshot attached). On debugging the code, I >>>>> found >>>>>>> that the following line of code in >>>>>>> ConnectorManagerUtils::getConnectorConfigs() returns an Enumeration >>>>>>> containing only two URLs: >>>>>>>> >>>>>>>> Enumeration<URL> appPathConfigs = >>>>>>> ConnectorManager.class.getClassLoader().getResources( >>>>>>>> ConfigurationConstants.FILENAME_CONNECTOR_PROPERTIES); >>>>>>>> >>>>>>>> Any pointers as to what might be wrong would be helpful. >>>>>>>> >>>>>>>> Thanks and regards >>>>>>>> Banmeet Singh >>>>>>>> Graduate Student >>>>>>>> Department of Computer Science >>>>>>>> Rutgers, The State University of New Jersey >>>>>>>> Mob.: (732)-779-9741 >>> >>
