-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40281/
-----------------------------------------------------------

(Updated Nov. 13, 2015, 7:54 a.m.)


Review request for Sqoop.


Bugs: SQOOP-2684
    https://issues.apache.org/jira/browse/SQOOP-2684


Repository: sqoop-sqoop2


Description
-------

Currently groovy version used in sqoop is 1.8.5. This version doesn't support 
space in command arguments(GROOVY-6942). This make it impossible to run 
commands like this start job "job name with whitespace". I'd like to propose to 
upgrade the groovy version to 2.4.0.


Diffs (updated)
-----

  shell/pom.xml c70c745 
  shell/src/main/java/org/apache/sqoop/shell/CloneCommand.java f71f82c 
  shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java ecea579 
  shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java b46a19f 
  shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java a16ba5b 
  shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java 03ceaba 
  shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java e392846 
  shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java 4b66505 
  shell/src/main/java/org/apache/sqoop/shell/DisableCommand.java 03aa922 
  shell/src/main/java/org/apache/sqoop/shell/EnableCommand.java 42cc9fc 
  shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java b4b77b0 
  shell/src/main/java/org/apache/sqoop/shell/HelpCommand.java e8d531f 
  shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java 0cb30e4 
  shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 3b8f4c2 
  shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 55a0f27 
  shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java 82c52da 
  shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java fdb7a5b 
  shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 33fddbf 
  shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 
  shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 5b4ef1f 
  shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 
  shell/src/main/java/org/apache/sqoop/shell/UpdateCommand.java c75d5f5 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java fe6a155 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java c5359ce 
  shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java 3a4a18d 
  shell/src/test/java/org/apache/sqoop/shell/TestCloneCommand.java c45501c 
  shell/src/test/java/org/apache/sqoop/shell/TestCreateCommand.java 2f91897 
  shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java d5df497 
  shell/src/test/java/org/apache/sqoop/shell/utils/TestConfigFiller.java 
1917a1d 

Diff: https://reviews.apache.org/r/40281/diff/


Testing
-------


Thanks,

Dian Fu

Reply via email to