[
https://issues.apache.org/jira/browse/SQOOP-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006113#comment-15006113
]
Sqoop QA bot commented on SQOOP-2688:
-------------------------------------
Testing file
[SQOOP-2688.patch|https://issues.apache.org/jira/secure/attachment/12772423/SQOOP-2688.patch]
against branch sqoop2 took 0:58:25.146463.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1640 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1888/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1888/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 99 tests)
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1888/console].
This message is automatically generated.
> Sqoop2: Provide utility method to safely retrieve value from JSONObject
> -----------------------------------------------------------------------
>
> Key: SQOOP-2688
> URL: https://issues.apache.org/jira/browse/SQOOP-2688
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2688.patch
>
>
> I've continued working on the umbrella JIRA SQOOP-2468 by injecting various
> invalid JSON snippets and I've noticed that is *extremely* easy to get
> {{NullPointerException}}. That is because we're anticipating certain
> structure in the JSON and we're not properly checking whether it's there or
> not.
> I would like to fix that by introducing util method that will properly verify
> if given key is available and whether it's of proper class instead of
> throwing not useful {{NullPointerException}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
