> On Nov. 16, 2015, 10:17 p.m., Abraham Fine wrote: > > test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java, > > line 263 > > <https://reviews.apache.org/r/40336/diff/1/?file=1125890#file1125890line263> > > > > a little concerning that this was broken and it did not impact the > > result of the tests. > > > > it seems that we are not actually testing the content of these > > responses. so why do we need to write them to a dataoutputstream?
The reason for that is that so far neigher of the REST-specific tests is actually testing sending data over - that is something that I'm working on right now and that is how I found this problem :) - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40336/#review106748 ----------------------------------------------------------- On Nov. 16, 2015, 12:15 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40336/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 12:15 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2689 > https://issues.apache.org/jira/browse/SQOOP-2689 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Corrected order. > > > Diffs > ----- > > > test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java > d083d37 > > Diff: https://reviews.apache.org/r/40336/diff/ > > > Testing > ------- > > The integration test seems to be passing. > > > Thanks, > > Jarek Cecho > >
