----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41079/#review109319 -----------------------------------------------------------
Ship it! Looks good to me, I have one single question: repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java (lines 632 - 634) <https://reviews.apache.org/r/41079/#comment168780> Are we planning to add a separate method that given Connector/Link/Job name will return the id without creating the whole MLink structure? Jarcec - Jarek Cecho On Dec. 8, 2015, 7:54 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41079/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 7:54 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Use link name in MJob > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9b9359b > common/src/main/java/org/apache/sqoop/json/JobBean.java b703987 > common/src/main/java/org/apache/sqoop/model/MJob.java 4be020a > common/src/test/java/org/apache/sqoop/json/TestJobBean.java 5b5aa91 > common/src/test/java/org/apache/sqoop/json/TestJobsBean.java 2a9570f > common/src/test/java/org/apache/sqoop/json/util/BeanTestUtil.java 13774c8 > common/src/test/java/org/apache/sqoop/model/TestMJob.java 17388cd > core/src/main/java/org/apache/sqoop/driver/JobManager.java 35c4451 > core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b200e9 > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > a665fd1 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > 586ef12 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > d1c3feb > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java > a9e1881 > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java > 53e4da5 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java > 18e33fc > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 80f7681 > shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java faad505 > shell/src/test/java/org/apache/sqoop/shell/TestCloneCommand.java 14daa87 > shell/src/test/java/org/apache/sqoop/shell/TestCreateCommand.java 89f4fe8 > shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 870bee3 > shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java 2a6670d > > Diff: https://reviews.apache.org/r/41079/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
