> On Dec. 10, 2015, 11:09 a.m., Jarek Cecho wrote: > > Overall looks good to me. I have couple of comments inline. It seems that > > there is findbugs warning and test coverage decrease significantly - > > perhaps we should improve unit test coverage for the new code?
I've also rerun the precommit hook to see if the failure is relevant. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41180/#review109736 ----------------------------------------------------------- On Dec. 10, 2015, 2:28 a.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41180/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 2:28 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2727 > https://issues.apache.org/jira/browse/SQOOP-2727 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Sqoop2: Use PreparedStatements for constructing GenericJDBCPartitions > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java > ff33a4b > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java > edb2754 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > fa26c14 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartition.java > 65400ef > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java > 2a42ed4 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java > 3b52128 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java > 3a767ab > > Diff: https://reviews.apache.org/r/41180/diff/ > > > Testing > ------- > > yup > > > Thanks, > > Abraham Fine > >
