----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41081/#review109897 -----------------------------------------------------------
Ship it! Ship It! - David Robson On Dec. 8, 2015, 7:30 a.m., David Robson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41081/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 7:30 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2723 > https://issues.apache.org/jira/browse/SQOOP-2723 > > > Repository: sqoop-trunk > > > Description > ------- > > Quoted the column names returned from Oracle. This will work fine as Oracle > always returns them in the correct case so we can safely quote them. > > > Diffs > ----- > > src/docs/user/connectors.txt c5ce4d6 > src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java 55a2b4c > src/java/org/apache/sqoop/manager/oracle/OraOopOracleQueries.java ea64c6d > src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatBase.java > 7c4d1c5 > > Diff: https://reviews.apache.org/r/41081/diff/ > > > Testing > ------- > > Manually tested a table with lowercase columns, also tested a table with > regular uppercase columns to ensure it still works. > > > Thanks, > > David Robson > >
