> On Dec. 7, 2015, 2:41 p.m., Jarek Cecho wrote: > > test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniCluster.java, > > line 74 > > <https://reviews.apache.org/r/40635/diff/11/?file=1154865#file1154865line74> > > > > Thinking about it, can we perhaps add new configuration option to > > JettyServer that in addition to port will accept also a hostname > > identifying on what interface we should start (with blank as a default)? > > This way, the method "getServerUrl" will return proper hostname instead of > > localhost and hence we would not have to do this monkey patching. > > > > I'm proposing that because this subtitution seems quite fragile to me > > :-(. If you agree, then let's do that in separate JIRA as that is > > standalone functionality that will be useful outside of this patch as well > > :) > > Dian Fu wrote: > Good advice. Will do that in separate JIRA. While for this JIRA, what > about keeping the current solution as I found that to it's not > straightforward to make the configured hostname usable in this patch. For > example, we need to know the hostname of the server to create principal for > sqoopserver in MiniKdcRunner and so we need to find a way to transfer the > configured hostname to MiniKdcRunner.
ACK, can you please create such JIRA and link it here Dian? - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40635/#review109148 ----------------------------------------------------------- On Dec. 11, 2015, 7:30 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40635/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 7:30 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2705 > https://issues.apache.org/jira/browse/SQOOP-2705 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > At the first step of providing kerberos support for integration tests, I'd > like to add kerberos support for SqoopMiniCluster make sure the communication > between sqoop client and sqoop server are kerberos enabled. > > > Diffs > ----- > > pom.xml e66de4d > test/pom.xml 4e1e197 > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > c1f355f > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/DatabaseInfrastructureProvider.java > e4481c4 > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/HadoopInfrastructureProvider.java > f6ba23c > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/InfrastructureProvider.java > d904b3e > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/KdcInfrastructureProvider.java > PRE-CREATION > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProvider.java > 2c8af9c > test/src/main/java/org/apache/sqoop/test/kdc/KdcRunner.java PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/KdcRunnerFactory.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/NoKerberosKdcRunner.java > PRE-CREATION > > test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniCluster.java > 325a790 > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 9ae941f > > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniClusterFactory.java > 544d419 > test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java > e3ee300 > test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 5964bcd > > test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java > fe04df7 > > test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java > 298ec09 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > b309c86 > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > e86a6cc > test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java > 20f09e8 > > Diff: https://reviews.apache.org/r/40635/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
