----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41633/#review111771 -----------------------------------------------------------
Ship it! I would love to see more tests (for example when the repo is not empty and such), but that seems to be outside of the scope of current work, hence +1 "Ship it!" :) - Jarek Cecho On Dec. 22, 2015, 8:02 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41633/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 8:02 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > RepositoryLoadTool and RepositoryDumpTool should be updated for remove id and > test cases are also needed. > > > Diffs > ----- > > test/pom.xml 5259d80 > > test/src/test/java/org/apache/sqoop/integration/tools/RepositoryDumpLoadToolTest.java > PRE-CREATION > test/src/test/resources/repoLoadToolTest.json PRE-CREATION > test/src/test/resources/tools-tests-suite.xml PRE-CREATION > tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 7df7f3b > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java > 42bcbd5 > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java > 8ba8d84 > > Diff: https://reviews.apache.org/r/41633/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
