[
https://issues.apache.org/jira/browse/SQOOP-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071501#comment-15071501
]
Sqoop QA bot commented on SQOOP-2757:
-------------------------------------
Testing file
[SQOOP-2757.001.patch|https://issues.apache.org/jira/secure/attachment/12779506/SQOOP-2757.001.patch]
against branch sqoop2 took 1:05:37.322412.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1646 tests)
{color:orange}WARNING:{color} Test coverage has decreased
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/2045/artifact/patch-process/cobertura_report.txt])
* Package {{connector/connector-sdk-hadoop}}: Can't compare test coverage as
base is missing.
{color:orange}WARNING:{color} New findbugs warnings
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/2045/artifact/patch-process/findbugs_report.txt])
* Package {{connector/connector-sdk-hadoop}}: Can't compare classes as base is
missing.
{color:green}SUCCESS:{color} All integration tests passed (executed 147 tests)
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/2045/console].
This message is automatically generated.
> Sqoop2: Add module connector-sdk-hadoop to hold hadoop specific SDK classes
> used by the connectors
> --------------------------------------------------------------------------------------------------
>
> Key: SQOOP-2757
> URL: https://issues.apache.org/jira/browse/SQOOP-2757
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Dian Fu
> Assignee: Dian Fu
> Fix For: 1.99.7
>
> Attachments: SQOOP-2757.001.patch
>
>
> As discussed in the review board of SQOOP-2752:
> {quote}
> I would prefer not to put hadoop as a depedency on connector-sdk. This would
> force every connector to synchronize with Hadoop dependencies (guava and
> such). Can we instead create a new module "connector-sdk-hadoop" that will
> contain Hadoop specific SDK classes and will in turn contain this Hadoop
> dependency (arguably if the connector needs something from Hadoop they should
> be fine with having hadoop jars on classpath). This way the connectors that
> doesn't need anything from hadoop don't end up having Hadoop's guava (and
> others) on the classpath.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
