----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41716/#review111922 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Dec. 25, 2015, 9:43 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41716/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2015, 9:43 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2757 > https://issues.apache.org/jira/browse/SQOOP-2757 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > As discussed in the review board of SQOOP-2752: > I would prefer not to put hadoop as a depedency on connector-sdk. This would > force every connector to synchronize with Hadoop dependencies (guava and > such). Can we instead create a new module "connector-sdk-hadoop" that will > contain Hadoop specific SDK classes and will in turn contain this Hadoop > dependency (arguably if the connector needs something from Hadoop they should > be fine with having hadoop jars on classpath). This way the connectors that > doesn't need anything from hadoop don't end up having Hadoop's guava (and > others) on the classpath. > > > Diffs > ----- > > connector/connector-hdfs/pom.xml d695750 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java > f06300a > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java > 441fe30 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java > 3a0d626 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java > a6551e6 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java > d01e932 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToDestroyer.java > 858042c > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java > 204c978 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/security/SecurityUtils.java > 0a42936 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/security/TestSecurityUtils.java > 713c704 > connector/connector-sdk-hadoop/pom.xml PRE-CREATION > > connector/connector-sdk-hadoop/src/main/java/org/apache/sqoop/connector/hadoop/security/SecurityUtils.java > PRE-CREATION > > connector/connector-sdk-hadoop/src/test/java/org/apache/sqoop/connector/hadoop/security/TestSecurityUtils.java > PRE-CREATION > connector/pom.xml be8fcb1 > pom.xml d7b0dd5 > server/pom.xml c24183c > > Diff: https://reviews.apache.org/r/41716/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
