-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41827/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 1:12 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2763
https://issues.apache.org/jira/browse/SQOOP-2763
Repository: sqoop-sqoop2
Description
-------
We happily accept non-existing arguments in the shell which is highly deceptive:
sqoop:000> set server --name x
Server is set successfully
sqoop:000>
or
sqoop:000> show connector --please
...
sqoop:000>
We should throw an exception or something if one is using
incorrect/non-existing arguments.
Diffs (updated)
-----
common/pom.xml 078a785
common/src/main/java/org/apache/sqoop/cli/SqoopGnuParser.java PRE-CREATION
shell/pom.xml 1949a8e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 0845d8e
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java 97b6e3b
shell/src/test/java/org/apache/sqoop/shell/TestCloneCommand.java 53303af
shell/src/test/java/org/apache/sqoop/shell/TestCreateCommand.java 1f559b6
shell/src/test/java/org/apache/sqoop/shell/TestDeleteCommand.java 4165bf0
shell/src/test/java/org/apache/sqoop/shell/TestDisableCommand.java a236685
shell/src/test/java/org/apache/sqoop/shell/TestEnableCommand.java 6ce78eb
shell/src/test/java/org/apache/sqoop/shell/TestGrantCommand.java 9f7f5b8
shell/src/test/java/org/apache/sqoop/shell/TestRevokeCommand.java 88f04f2
shell/src/test/java/org/apache/sqoop/shell/TestSetCommand.java b231cf2
shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 6463bd5
shell/src/test/java/org/apache/sqoop/shell/TestStartCommand.java b55b087
shell/src/test/java/org/apache/sqoop/shell/TestStatusCommand.java 9fac463
shell/src/test/java/org/apache/sqoop/shell/TestStopCommand.java e2bc6b8
shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java f5062da
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java
6958ee1
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java
748ef80
Diff: https://reviews.apache.org/r/41827/diff/
Testing
-------
Thanks,
Dian Fu