[
https://issues.apache.org/jira/browse/SQOOP-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103557#comment-15103557
]
Ze Jin commented on SQOOP-2753:
-------------------------------
The import in line 7 is never used. The field in line 13 is not used, and
methods in class SqoopJsonUtil are all static, so any intance of SqoopJsonUtil
is unnecessary. According to the method name testMapToStringAndBack, I think
Line 31 should change to Map<String, String> resultMap =
SqoopJsonUtil.getMapforJsonString(resultJsonStr);
> TestSqoopJsonUtil.testGetJsonStringFromMap is depending on Map ordering in JDK
> ------------------------------------------------------------------------------
>
> Key: SQOOP-2753
> URL: https://issues.apache.org/jira/browse/SQOOP-2753
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.4.6
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.4.7
>
> Attachments: SQOOP-2753.patch
>
>
> The test is comparing hardcoded string that represents map, however map order
> is JDK version specific thus resulting in:
> {code}
> junit.framework.AssertionFailedError:
> expected:<{"k[3":"v3","k1":"v1","k2":"v2]"}> but
> was:<{"k[1":"v1","k2":"v2","k3":"v3]"}>
> at
> org.apache.sqoop.util.TestSqoopJsonUtil.testGetJsonStringFromMap(TestSqoopJsonUtil.java:31)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
