----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42446/#review115202 -----------------------------------------------------------
common/src/main/java/org/apache/sqoop/json/ThreadDumpBean.java (line 45) <https://reviews.apache.org/r/42446/#comment176101> not sure what this comment means common/src/main/java/org/apache/sqoop/utils/ReflectionUtils.java (line 28) <https://reviews.apache.org/r/42446/#comment176105> can be used instead of... ? common/src/main/java/org/apache/sqoop/utils/ReflectionUtils.java (line 30) <https://reviews.apache.org/r/42446/#comment176106> are we only including this class because the ReflectionUtils class included in one version of hadoop results in a firebugs warning? it seems strange to me to not use a hadoop class because firebugs is unhappy with it. isn't hadoop a "provided" dependency anyway? perhaps it would make more sense to ignore the firebugs warning rather than writing a whole new class? server/src/main/java/org/apache/sqoop/handler/ThreadDumpRequestHandler.java (line 41) <https://reviews.apache.org/r/42446/#comment176104> would returning an http code 405 make any sense here? shell/src/main/java/org/apache/sqoop/shell/core/Constants.java (line 489) <https://reviews.apache.org/r/42446/#comment176103> nitpick: make this match the indentation of the other constants test/src/test/java/org/apache/sqoop/integration/shell/ShowCommandTest.java (line 41) <https://reviews.apache.org/r/42446/#comment176102> why do we need this? - Abraham Fine On Jan. 18, 2016, 5:45 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42446/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 5:45 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Add web interface for thread dump, user can get the information from the > shell. > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java 1cf549e > > client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java > 33c90a8 > > client/src/main/java/org/apache/sqoop/client/request/ThreadDumpResourceRequest.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/json/ThreadDumpBean.java PRE-CREATION > common/src/main/java/org/apache/sqoop/utils/ReflectionUtils.java > PRE-CREATION > server/src/main/java/org/apache/sqoop/handler/ThreadDumpRequestHandler.java > PRE-CREATION > server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a > server/src/main/java/org/apache/sqoop/server/ThreadDumpServlet.java > PRE-CREATION > shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java eb8522a > shell/src/main/java/org/apache/sqoop/shell/ShowThreadDumpFunction.java > PRE-CREATION > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 9c57a2e > shell/src/main/resources/shell-resource.properties 630c31d > test/src/test/java/org/apache/sqoop/integration/shell/ShowCommandTest.java > 9fd4811 > > Diff: https://reviews.apache.org/r/42446/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
