[
https://issues.apache.org/jira/browse/SQOOP-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109944#comment-15109944
]
Sqoop QA bot commented on SQOOP-2786:
-------------------------------------
Testing file
[SQOOP-2786.patch|https://issues.apache.org/jira/secure/attachment/12783486/SQOOP-2786.patch]
against branch sqoop2 took 1:06:41.564853.
{color:red}Overall:{color} -1 due to an error(s), see details below:
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:red}ERROR:{color} Patch does not add/modify any test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1676 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/2122/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/2122/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 194 tests)
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/2122/console].
This message is automatically generated.
> Sqoop2: If AUTHENTICATION_KERBEROS_KEYTAB is not found in the properties
> throw a meaningful exception
> -----------------------------------------------------------------------------------------------------
>
> Key: SQOOP-2786
> URL: https://issues.apache.org/jira/browse/SQOOP-2786
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 1.99.6
> Reporter: Abraham Fine
> Assignee: Abraham Fine
> Attachments: SQOOP-2786.patch
>
>
> Currently we have:
> {code:java}
> MapContext mapContext = SqoopConfiguration.getInstance().getContext();
> String keytab = mapContext.getString(
> SecurityConstants.AUTHENTICATION_KERBEROS_KEYTAB).trim();
> {code}
> If SecurityConstants.AUTHENTICATION_KERBEROS_KEYTAB is not found in the
> properties we throw a null pointer exception. Our exception should indicate
> exactly which property is not found.
> It may also be useful to log something when we need to revert to a default
> value when we do something like:
> {code:java}
> SqoopConfiguration.getInstance().getContext().getBoolean(RepoConfigurationConstants.SYSCFG_REPO_SCHEMA_IMMUTABLE,
> true));
> {code}
> to always indicate where we are not using configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
