> On Jan. 26, 2016, 6:45 p.m., Abraham Fine wrote: > > +1 but would you mind updating the jira with some information around the > > motivation for this change (I think it may help for future reference)?
Hi Abe, Thanks a lot for the review. :) Updated the patch to fix an issue just found. For the motivation of this change, currently the integration tests have two inheritance paths: SqoopTestCase and JettyTestCase. We want to simplity it and switch all the integration tests to SqoopTestCase and then all the integration tests can make use of the infrastructure mechanism. I will update the JIRA description. - Dian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42793/#review116401 ----------------------------------------------------------- On Jan. 27, 2016, 2:12 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42793/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 2:12 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2762 > https://issues.apache.org/jira/browse/SQOOP-2762 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Provide test infrastructure base class for connector loading tests > > > Diffs > ----- > > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > f071786 > test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java > d4ca396 > > test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java > 66c20a1 > > test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java > 4aed991 > > test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java > 295e049 > > Diff: https://reviews.apache.org/r/42793/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
