-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42931/#review116947
-----------------------------------------------------------



Thanks for testing this @Balu.   

Also can we add a small doc note that this is the currently for imports and 
will be enhanced for exports also


src/java/org/apache/sqoop/SqoopJobDataPublisher.java (line 115)
<https://reviews.apache.org/r/42931/#comment178027>

    Let us add them as String constants so that we can refer them in tests and 
in other places



src/java/org/apache/sqoop/mapreduce/ImportJobBase.java (line 284)
<https://reviews.apache.org/r/42931/#comment178028>

    Let us move this as a constant to ConfigurationConstants


- Venkat Ranganathan


On Jan. 28, 2016, 4:23 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42931/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 4:23 p.m.)
> 
> 
> Review request for Sqoop and Venkat Ranganathan.
> 
> 
> Bugs: sqoop-2609
>     https://issues.apache.org/jira/browse/sqoop-2609
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> We would like to provide lineage information to Apache Atlas when data is 
> ingested into Hive via Sqoop as the first step.
> 
> This will allow us to identify the lineage of data.
> 
> 
> Diffs
> -----
> 
>   conf/sqoop-site-template.xml 368af26 
>   src/java/org/apache/sqoop/SqoopJobDataPublisher.java PRE-CREATION 
>   src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 04d60fd 
>   src/test/org/apache/sqoop/TestSqoopJobDataPublisher.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42931/diff/
> 
> 
> Testing
> -------
> 
> end2end testing done.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>

Reply via email to