----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42918/#review116949 -----------------------------------------------------------
Fix it, then Ship it! LGTM. Minor nits below. Please fix and update a new patch and will commit src/java/org/apache/sqoop/manager/MySQLManager.java (line 71) <https://reviews.apache.org/r/42918/#comment178031> Let us make this as a separate String constant src/java/org/apache/sqoop/manager/MySQLManager.java (line 73) <https://reviews.apache.org/r/42918/#comment178030> Can we add one comment saying that even though we set fetchsize to 0, it would not overwhelm the JVM (even with incompatible driver versions) as the queries during export are primarily metadata queries L - Venkat Ranganathan On Jan. 28, 2016, 12:02 p.m., Sowmya Ramesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42918/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 12:02 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2787 > https://issues.apache.org/jira/browse/SQOOP-2787 > > > Repository: sqoop-trunk > > > Description > ------- > > As discussed in SQOOP-1400 and SQOOP-1617, there are combinations and > versions of MySQL server and driver that cause the import and export to fail > when the metadata of the tables are being fetched. > > Trace: > 16/01/07 21:48:14 DEBUG manager.SqlManager: No connection paramenters > specified. Using regular API for making connection. > 16/01/07 21:48:14 DEBUG manager.SqlManager: Using fetchSize for next query: > -2147483648 > 16/01/07 21:48:14 INFO manager.SqlManager: Executing SQL statement: SELECT > t.* FROM `t1` AS t LIMIT 1 > 16/01/07 21:48:14 DEBUG manager.SqlManager: Found column col1 of type 4, 11, 0 > 16/01/07 21:48:14 ERROR manager.SqlManager: Error reading from database: > java.sql.SQLException: Streaming result set > com.mysql.jdbc.RowDataDynamic@17980bdc is still active. No statements may be > issued when any streaming result sets are open and in use on a given > connection. Ensure that you have called .close() on any active streaming > result sets before attempting more queries. > java.sql.SQLException: Streaming result set > com.mysql.jdbc.RowDataDynamic@17980bdc is still active. No statements may be > issued when any streaming result sets are open and in use on a given > connection. Ensure that you have called .close() on any active streaming > result sets before attempting more queries. > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:934) > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:931) > at com.mysql.jdbc.MysqlIO.checkForOutstandingStreamingData(MysqlIO.java:2735) > at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:1899) > > > Diffs > ----- > > src/java/org/apache/sqoop/SqoopOptions.java db92b30 > src/java/org/apache/sqoop/manager/MySQLManager.java e1d5a36 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java a7f6aec > > Diff: https://reviews.apache.org/r/42918/diff/ > > > Testing > ------- > > Manual testing > > > Thanks, > > Sowmya Ramesh > >
