----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41971/#review117879 -----------------------------------------------------------
test/src/main/java/org/apache/sqoop/test/kdc/NoKerberosKdcRunner.java (line 31) <https://reviews.apache.org/r/41971/#comment179132> can we possibly refactor the code to avoid needing this class. it seems confusing to me to have a kerberos runner for not running kerberos. test/src/test/resources/integration-tests-suite.xml (line 30) <https://reviews.apache.org/r/41971/#comment179131> can we possibly still run these tests without using kerberos? i would hate to see a change that breaks these tests sneak through because we are waiting to make these tests work with kerberos. this is awesome. i learned a lot about how kerberos works in hadoop just by reading this code. i left a couple minor comments. - Abraham Fine On Jan. 29, 2016, 8:46 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41971/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 8:46 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2744 > https://issues.apache.org/jira/browse/SQOOP-2744 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > The aim of this JIRA is to enable kerberos for HadoopMiniCluster. > > > Diffs > ----- > > test/pom.xml 644a9c7 > > test/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.java > 2c0c4e6 > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > 74fe29b > test/src/main/java/org/apache/sqoop/test/kdc/KdcRunner.java aa5c6fc > test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 299fd9f > test/src/main/java/org/apache/sqoop/test/kdc/NoKerberosKdcRunner.java > 29a005e > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 4ff97e7 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java > e5e3d26 > > test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java > ec9f733 > > test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java > 1c7a483 > > test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java > 5e49064 > > test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java > bbbf749 > test/src/test/resources/hive-tests-suite.xml PRE-CREATION > test/src/test/resources/integration-tests-suite.xml 1cf3299 > > Diff: https://reviews.apache.org/r/41971/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
