-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44097/
-----------------------------------------------------------

Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-2853
    https://issues.apache.org/jira/browse/SQOOP-2853


Repository: sqoop-sqoop2


Description
-------

I would like to refactor the existing 
{{[TableDisplayer|https://github.com/apache/sqoop/blob/sqoop2/shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java]}},
 so that it can generate tables for documentation as well. Right now that class 
is too tight with the way shell works.


Diffs
-----

  shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712 
  shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java d973499 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java ebbfe82 
  shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 25bd1db 
  shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java a450aaf 
  shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java 2cf6972 
  shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java 6b61921 
  shell/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.java 
8989913 
  shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java 51030d0 
  shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 49affa3 

Diff: https://reviews.apache.org/r/44097/diff/


Testing
-------


Thanks,

Jarek Cecho

Reply via email to