-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44212/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2858
    https://issues.apache.org/jira/browse/SQOOP-2858


Repository: sqoop-trunk


Description
-------

I've added the missing code from JdbcExportJob to JdbcUpdateExportJob. There is 
huge opportunity to refactore those two classes to reuse code much better, but 
I did not wanted to do huge reactorings to that code, I've chose path of 
copy&pasting mostly.


Diffs
-----

  src/java/org/apache/sqoop/mapreduce/ExportJobBase.java 32de92a 
  src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java 78df33c 
  src/java/org/apache/sqoop/mapreduce/JdbcUpdateExportJob.java 8fa420e 
  src/test/com/cloudera/sqoop/TestAvroExport.java 137a6e1 
  src/test/com/cloudera/sqoop/TestParquetExport.java 86b40fb 

Diff: https://reviews.apache.org/r/44212/diff/


Testing
-------

I've added new unit tests that are covering update mode for both Parquet and 
Avro.


Thanks,

Jarek Cecho

Reply via email to