> On March 1, 2016, 8:07 p.m., Abraham Fine wrote: > > server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java, > > line 144 > > <https://reviews.apache.org/r/43857/diff/2/?file=1268499#file1268499line144> > > > > perhaps there is a better way of handling this. i can imagine multiple > > different servererrors mapping to different http status codes. > > > > I would understand if you felt that this would be best suited for a > > different jira.
Yup, I would take that discussion to a separate JIRA - feel free to create one with your thoughts :) - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43857/#review121482 ----------------------------------------------------------- On Feb. 24, 2016, 11:26 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43857/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 11:26 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-2545 > https://issues.apache.org/jira/browse/SQOOP-2545 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I would like to see (&test) what happens when I call some random non-existing > REST URLs to our server. > > > Diffs > ----- > > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > b894e37 > server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java > fb4a99f > > test/src/test/java/org/apache/sqoop/integration/server/rest/ConnectorRestTest.java > 839a4d0 > > test/src/test/java/org/apache/sqoop/integration/server/rest/NonExistingRestTest.java > PRE-CREATION > > test/src/test/java/org/apache/sqoop/integration/server/rest/VersionRestTest.java > e4c89df > > Diff: https://reviews.apache.org/r/43857/diff/ > > > Testing > ------- > > > Thanks, > > Jarek Cecho > >
