----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44302/#review122124 -----------------------------------------------------------
Ship it! Thanks for a quick fix - Venkat Ranganathan On March 2, 2016, 2:49 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44302/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 2:49 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2864 > https://issues.apache.org/jira/browse/SQOOP-2864 > > > Repository: sqoop-trunk > > > Description > ------- > > I've added code that is specifically handling double quotes. I'm anticipating > that we might need to extend it in the future with more prolematic characters > as we find out what else are popular RDBMS allowing. > > > Diffs > ----- > > src/java/org/apache/sqoop/orm/ClassWriter.java 95c655d > > Diff: https://reviews.apache.org/r/44302/diff/ > > > Testing > ------- > > Creating automated test for this one is super problematical because the > build-in HSQDB that we're using for testing doesn't support double quotes in > column names. I did however tested the code on real cluster against MySQL. > > > Thanks, > > Jarek Cecho > >
