> On March 1, 2016, 8:44 p.m., Abraham Fine wrote: > > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java, line > > 276 > > <https://reviews.apache.org/r/43783/diff/2/?file=1263214#file1263214line276> > > > > perhaps this "all" should be stored in a constant somewhere as it is a > > special case? > > > > also, slightly unrelated, do you know if we have a mechanism to prevent > > the creation of connectors or links named "all"?
Excellent points 1) I should do the change everywhere, so I'll cover it in separate JIRA: https://issues.apache.org/jira/browse/SQOOP-2867 2) Filled https://issues.apache.org/jira/browse/SQOOP-2868 to cover it. > On March 1, 2016, 8:44 p.m., Abraham Fine wrote: > > test/src/test/java/org/apache/sqoop/integration/server/rest/JobRestTest.java, > > line 37 > > <https://reviews.apache.org/r/43783/diff/2/?file=1263215#file1263215line37> > > > > nit: could we avoid duplicating this validator code? Will incorporate to next version. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43783/#review121485 ----------------------------------------------------------- On Feb. 19, 2016, 9:17 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43783/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 9:17 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-2848 > https://issues.apache.org/jira/browse/SQOOP-2848 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I would like to simplify the {{JobRequestHandler.getJobs}} similarly as we've > changed for {{LinkRequestHandler.getLinks}} back in SQOOP-2670. > > > Diffs > ----- > > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 3070059 > > test/src/test/java/org/apache/sqoop/integration/server/rest/JobRestTest.java > PRE-CREATION > test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java > 5b3a7bf > > Diff: https://reviews.apache.org/r/43783/diff/ > > > Testing > ------- > > > Thanks, > > Jarek Cecho > >
