> On March 5, 2016, 3:21 a.m., Abraham Fine wrote: > > connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties, > > line 51 > > <https://reviews.apache.org/r/44103/diff/1/?file=1272653#file1272653line51> > > > > examples may be helpful here with respect to "how" these should be > > entered > > Jarek Cecho wrote: > I would prefer to stay away from "how" as the text can be used in several > different scenarios: > > * Command line (where the "how" would make sense) > * In documentation (purpose of those changes) > * In Hue application (GUI) > > Abraham Fine wrote: > i should have been more clean. i meant an example
Got it. Will add the "example" property. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44103/#review122179 ----------------------------------------------------------- On Feb. 26, 2016, 9:46 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44103/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 9:46 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-2855 > https://issues.apache.org/jira/browse/SQOOP-2855 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > See parent JIRA for details of what&why is being done here. > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties > 8256beb > > Diff: https://reviews.apache.org/r/44103/diff/ > > > Testing > ------- > > > Thanks, > > Jarek Cecho > >
