-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44595/
-----------------------------------------------------------
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-2495
https://issues.apache.org/jira/browse/SQOOP-2495
Repository: sqoop-sqoop2
Description
-------
On internal hackathon we we're hacking Sqoop 2 connector with [~singhashish]
and we went through few troubles that we should address.
We have a lot of requirements for Sqoop connectors that are only documented but
not enforced by the code, for example:
* Resource bundles need to have names for all properties in configuration
objects
* Configuration objects needs to be properly annotated
If either of those is incorrect then we happily load the connector just to
throw some random exceptions during runtime. We should provide simple test case
that all connectors can reuse to validate that connector is properly formed as
Sqoop expects.
(Which still doesn't mean that the connector will work as we can't guarantee
that extractor/loader is properly implemented. But we can at least help people
to not see random exceptions such as those described in SQOOP-2494).
Diffs
-----
connector/connector-ftp/pom.xml a330266
connector/connector-ftp/src/test/java/org/apache/sqoop/connector/ftp/TestFtpConnector.java
PRE-CREATION
connector/connector-generic-jdbc/pom.xml 8d054c1
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnector.java
cc1c58f
connector/connector-hdfs/pom.xml 37cf3fa
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsConnector.java
b41bd5a
connector/connector-kafka/pom.xml 5f41181
connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnector.java
2b03fa0
connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestKafkaConnector.java
PRE-CREATION
connector/connector-kite/pom.xml a492c5b
connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteConnector.java
c28f697
connector/connector-oracle-jdbc/pom.xml 4262cb2
connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/TestOracleJdbcConnector.java
PRE-CREATION
connector/connector-sdk-test/pom.xml PRE-CREATION
connector/connector-sdk-test/src/main/java/org/apache/sqoop/connector/spi/SqoopConnectorAsserts.java
PRE-CREATION
connector/connector-sftp/pom.xml 8db1af5
connector/connector-sftp/src/test/java/org/apache/sqoop/connector/sftp/TestSftpConnector.java
PRE-CREATION
connector/pom.xml 7340b37
pom.xml 891b2c9
Diff: https://reviews.apache.org/r/44595/diff/
Testing
-------
Thanks,
Jarek Cecho
