----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45559/#review127820 -----------------------------------------------------------
Nice work, thank you! core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java (line 483) <https://reviews.apache.org/r/45559/#comment191200> It seems that the other create* methods are using method setPersistanceId rather then returning the id as a return value. Can we perhaps do the same here? Jarcec - Jarek Cecho On April 5, 2016, 10:28 p.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45559/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 10:28 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2890 > https://issues.apache.org/jira/browse/SQOOP-2890 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Provide tooling to encrypt non-encrypted repository and rotate keys > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java > dd52c82 > core/src/main/java/org/apache/sqoop/driver/Driver.java 2d1d73e > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 44ab41b > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > 94f5e6f > core/src/main/java/org/apache/sqoop/repository/MasterKeyManager.java > df84d54 > core/src/main/java/org/apache/sqoop/repository/Repository.java c2e3c74 > core/src/main/java/org/apache/sqoop/security/SecurityError.java 2ba849c > core/src/test/java/org/apache/sqoop/repository/TestMasterKeyManager.java > f9579bf > dist/src/main/conf/sqoop.properties 58b60fd > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > a9168ae > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > d527290 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java > b4f66bb > test/pom.xml 4bac683 > > test/src/test/java/org/apache/sqoop/integration/tools/RepositoryDumpLoadToolTest.java > c1a10bc > > test/src/test/java/org/apache/sqoop/integration/tools/RepositoryEncryptionToolTest.java > PRE-CREATION > tools/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.java 13a2c5f > > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryEncryptionTool.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45559/diff/ > > > Testing > ------- > > > Thanks, > > Abraham Fine > >
