> On April 11, 2016, 8:24 p.m., Jarek Cecho wrote: > > docs/src/site/sphinx/security/Encryption.rst, lines 136-140 > > <https://reviews.apache.org/r/45860/diff/1/?file=1329294#file1329294line136> > > > > Or the passwrod generator: :: > > <TAB> org.a.... > > > > > > (e.g. you can save the empty line and line with just ::)
good point, but i will continue to do it this way to keep with the current convention across our other docs > On April 11, 2016, 8:24 p.m., Jarek Cecho wrote: > > docs/src/site/sphinx/security/Encryption.rst, lines 191-192 > > <https://reviews.apache.org/r/45860/diff/1/?file=1329294#file1329294line191> > > > > Can we document all the tools in one section of the guide please? > > > > We can always refer from here to the tools guide if needed. We have > > something like that for example in section about upgrades where we're > > referring to the upgrade tool. good point > On April 11, 2016, 8:24 p.m., Jarek Cecho wrote: > > docs/src/site/sphinx/security/Encryption.rst, line 201 > > <https://reviews.apache.org/r/45860/diff/1/?file=1329294#file1329294line201> > > > > s/which should/which will/ good catch - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45860/#review127823 ----------------------------------------------------------- On April 8, 2016, 7:53 p.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45860/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 7:53 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2891 > https://issues.apache.org/jira/browse/SQOOP-2891 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Repository encryption documentation > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java > dd52c820a0c069e506863a34d5dbdcb0a2f903f0 > core/src/main/java/org/apache/sqoop/driver/Driver.java > 2d1d73ec27db3d24c100947ec982652b03fc4e9e > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java > 44ab41b9575524456420993b062be9a40e91b829 > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > 94f5e6f17beb0cdae8a5eebf1d8be6625aefc14e > core/src/main/java/org/apache/sqoop/repository/MasterKeyManager.java > df84d540f8c6ede765709443ff4e2f5117f6847b > core/src/main/java/org/apache/sqoop/repository/Repository.java > c2e3c749413296fa23ae90c1aac85440fcf7a2b1 > core/src/main/java/org/apache/sqoop/security/SecurityError.java > 2ba849c3abcc667e901aa4ec55d8c467316f1dee > core/src/test/java/org/apache/sqoop/repository/TestMasterKeyManager.java > f9579bf3dc7b74149487f6a892792afe58a75e83 > dist/src/main/conf/sqoop.properties > 58b60fd192f3332dc7109ad7fc344ebb61e6e9a4 > docs/src/site/sphinx/admin/Tools.rst > 36fc231b5febc94d4860611e62d187bbac552df0 > docs/src/site/sphinx/security/Encryption.rst > 6471a07be46dc4c10e5ac40a0159d14fb9543b02 > docs/src/site/sphinx/security/RepositoryEncryption.rst PRE-CREATION > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > a9168aee6379cb1b367e475d9bdc352be82aa482 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > d527290908131cda899f407ce439b77b9d167752 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java > b4f66bb61e3112c66cdf8a6bed659262ff63a55e > test/pom.xml 4bac683d9497d7c6f24d1db4bd385efc3be566a3 > > test/src/test/java/org/apache/sqoop/integration/tools/RepositoryDumpLoadToolTest.java > c1a10bc32fc093b0a121bc4a2df363e3dbedd485 > > test/src/test/java/org/apache/sqoop/integration/tools/RepositoryEncryptionToolTest.java > PRE-CREATION > tools/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.java > 13a2c5f234840e422eb67db63d17645a865e23e9 > > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryEncryptionTool.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45860/diff/ > > > Testing > ------- > > > Thanks, > > Abraham Fine > >
