----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48100/#review135726 -----------------------------------------------------------
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java (line 93) <https://reviews.apache.org/r/48100/#comment200776> Maybe we can extract the common initialization part (creation of LinkConfiguration, ToJobConfiguration, etc.) from the test methods to a before method. That would decrease the code duplication and would probably make the test cases cleaner. test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java (line 117) <https://reviews.apache.org/r/48100/#comment200779> I guess we could use a before method in this test class as well. - Szabolcs Vasas On May 31, 2016, 10:44 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48100/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 10:44 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2941 > https://issues.apache.org/jira/browse/SQOOP-2941 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > A new option has been implemented to re-create target directory if it exists > in HDFS connector > > > Diffs > ----- > > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java > 70e0fde > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java > d76ba5f > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java > 5441702 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java > 330da56 > > Diff: https://reviews.apache.org/r/48100/diff/ > > > Testing > ------- > > Integration tests have been extended and executed. > > > Thanks, > > Boglarka Egyed > >
