----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50987/ -----------------------------------------------------------
(Updated Aug. 19, 2016, 5:15 p.m.) Review request for Sqoop. Changes ------- Added validation and test for Export tool (checked that JobTool automatically calls the "childTool" validation as well) Bugs: SQOOP-2913 https://issues.apache.org/jira/browse/SQOOP-2913 Repository: sqoop-trunk Description ------- SQOOP-2913: Make sqoop fail if user uses --direct connector for case when --direct connector is not available Diffs (updated) ----- src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java a5f72f7 src/java/org/apache/sqoop/manager/DefaultManagerFactory.java 58ff745 src/java/org/apache/sqoop/manager/Manager.java PRE-CREATION src/java/org/apache/sqoop/tool/ExportTool.java 15ecddf src/java/org/apache/sqoop/tool/ImportTool.java ff7b822 src/test/com/cloudera/sqoop/TestDirectImport.java PRE-CREATION src/test/org/apache/sqoop/manager/TestDefaultManagerFactory.java PRE-CREATION src/test/org/apache/sqoop/tool/TestExportToolValidateOptions.java PRE-CREATION src/test/org/apache/sqoop/tool/TestValidateImportOptions.java PRE-CREATION Diff: https://reviews.apache.org/r/50987/diff/ Testing ------- Added new test cases Thanks, Anna Szonyi