> On août 22, 2016, 1:55 après-midi, Erzsebet Szilagyi wrote: > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java, > > line 234 > > <https://reviews.apache.org/r/50655/diff/1/?file=1459076#file1459076line234> > > > > I'm curious about why you've removed this LOG line?
Hi, It is just a mistake. I will fix it. Thanks for reviewing ! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50655/#review146346 ----------------------------------------------------------- On août 22, 2016, 8:42 après-midi, Benjamin BONNET wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50655/ > ----------------------------------------------------------- > > (Updated août 22, 2016, 8:42 après-midi) > > > Review request for Sqoop, David Robson, Jarek Cecho, and Kathleen Ting. > > > Repository: sqoop-trunk > > > Description > ------- > > See on JIRA https://issues.apache.org/jira/browse/SQOOP-2991 > > > Diffs > ----- > > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java > 2efea53 > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaJDBCStatementRunner.java > cedfd23 > > Diff: https://reviews.apache.org/r/50655/diff/ > > > Testing > ------- > > Tested with requests that throw errors on Netezza side : importing with a > user that has not enough rights to create an external table. Without patch, > import fails but map reduce job never ends, with patch, import fails, map > reduce job ends with an IOException. > > > Thanks, > > Benjamin BONNET > >
