----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51159/#review147279 -----------------------------------------------------------
Ship it! Thank you for also improving on our tests! - Erzsebet Szilagyi On Aug. 17, 2016, 8:30 a.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51159/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 8:30 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2998 > https://issues.apache.org/jira/browse/SQOOP-2998 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Sqoop2: Strings with a ' (single quote) read from hdfs may be improperly > escaped > > > Diffs > ----- > > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java > 7cef93c35ba87840bc6d49a8c7167b3721c6be6a > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/hdfsWriter/GenericHdfsWriter.java > 31023e7360300f00c3528cfb33170ed4e9e8ab6f > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/hdfsWriter/HdfsParquetWriter.java > 4ec813b0f263df2cc8f08781bc40946341eda0c9 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/hdfsWriter/HdfsSequenceWriter.java > dcce861784301ca62bf18319639e06f2604d3362 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/hdfsWriter/HdfsTextWriter.java > 384e3309138a0f7fd525febbf3452b654ff0e5d0 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java > cbd555a8e4deb44f162bda14e721d0fc60ad9425 > test/src/main/java/org/apache/sqoop/test/data/Cities.java > f2c69bb406e5cc78705910b94842bc3b39f5126a > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java > 68855257cc4d64a3fbbfaaaa72f79e36343e724e > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/FromHDFSToHDFSTest.java > c6ce1e879e70d80ac8089313281d5adf08f4ed69 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/HdfsIncrementalReadTest.java > 37306e2e21780085a2fe8aa8541c04e398712678 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/NullValueTest.java > 1e8c688c28c1114e08f9941536a75656167e2a7f > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java > 330da56fa04fb2ecd84cbdc643b0cc1bf097b313 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/ParquetTest.java > d55563dd62f0cb1eb2b1d4f2bf4325ee1d9fda52 > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/S3Test.java > c8576999c175243df96071a7535499eaf4c3d8f9 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java > 933bc08da00aacae2e1d5cd52a463cc52c7c8c3d > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > 7e6609183378d5374e86d0b6c1d94509ca8f5f8e > > test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java > 10f36144d77c275fcad74397ca2f42fe67ab918f > > Diff: https://reviews.apache.org/r/51159/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Abraham Fine > >
