----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50155/ -----------------------------------------------------------
(Updated Sept. 6, 2016, 11:06 p.m.) Review request for Sqoop, David Robson, Jarek Cecho, and Kathleen Ting. Changes ------- Dear David, I tend to agree with you that this review does not head into the right direction, thus regardless your first request I suggest omitting the update related performance fix from this version, and I suggest to handle it as part of a very different JIRA task. Please review this changes as it is (it's just an earlier version of the code + the more robust test cases). Many thanks, Attila Repository: sqoop-trunk Description ------- Proposed changes for SQOOP-2983 Diffs (updated) ----- src/java/org/apache/sqoop/manager/oracle/OraOopOracleQueries.java 6b27bd8 src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatInsert.java d5eebf4 src/java/org/apache/sqoop/orm/ClassWriter.java 9d91887 src/test/org/apache/sqoop/manager/oracle/ExportTest.java 991b221 src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java 9fe4821 src/test/org/apache/sqoop/manager/oracle/OraOopTypesTest.java PRE-CREATION src/test/org/apache/sqoop/manager/oracle/util/OracleData.java 8846f65 Diff: https://reviews.apache.org/r/50155/diff/ Testing ------- 800 columns with table 100.000 lines (156mb data) 1.000.000 lines (1.56 GB data) 3.000.000 lines (4.5 GB data) Thanks, Attila Szabo
