-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51854/#review149195
-----------------------------------------------------------


Fix it, then Ship it!





src/test/com/cloudera/sqoop/hive/TestHiveImport.java (line 417)
<https://reviews.apache.org/r/51854/#comment216749>

    Could you fix the indentation please?



src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java (line 167)
<https://reviews.apache.org/r/51854/#comment216750>

    I think this method name is missing a 't':
    testHCatExporWithParquetFile() --> testHCatExportWithParquetFile()


- Erzsebet Szilagyi


On Sept. 15, 2016, 1:35 a.m., Sowmya Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51854/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 1:35 a.m.)
> 
> 
> Review request for Sqoop and Venkat Ranganathan.
> 
> 
> Bugs: SQOOP-3010
>     https://issues.apache.org/jira/browse/SQOOP-3010
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> sqoop import ... --create-hcatalog-table --hcatalog-table --as-parquetfile
> 
> 
> Error: java.lang.RuntimeException: Should never be used
>               at 
> org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat.getRecordWriter(MapredParquetOutputFormat.java:76)
>               at 
> org.apache.hive.hcatalog.mapreduce.FileOutputFormatContainer.getRecordWriter(FileOutputFormatContainer.java:103)
>         
> This should not run and should display a validation error as it does for both 
> --as-sequencefile and --as-avrodatafile but the job runs and fails later with 
> RuntimeException
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43 
>   src/test/com/cloudera/sqoop/hive/TestHiveImport.java b626964 
>   src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java 5cd4c26 
> 
> Diff: https://reviews.apache.org/r/51854/diff/
> 
> 
> Testing
> -------
> 
> UTs added
> 
> 
> Thanks,
> 
> Sowmya Ramesh
> 
>

Reply via email to