----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53423/#review154722 -----------------------------------------------------------
src/java/org/apache/sqoop/SqoopOptions.java (line 2667) <https://reviews.apache.org/r/53423/#comment224390> Some space diffs :) src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 61) <https://reviews.apache.org/r/53423/#comment224388> I usually see the args stored without the -- in the code, though the hasOption strips the hyphens, it may make sense to make it more the way the rest of the args are stored? src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 1038) <https://reviews.apache.org/r/53423/#comment224389> Would it make sense to extract these into constants? Super awesome job Attila! Would it make sense to write a test case for this? Thanks, /Anna - Anna Szonyi On Nov. 3, 2016, 12:37 p.m., Attila Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53423/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 12:37 p.m.) > > > Review request for Sqoop, Abraham Elmahrek, Abraham Fine, Boglarka Egyed, > Anna Szonyi, Szabolcs Vasas, and Erzsebet Szilagyi. > > > Bugs: SQOOP-2349 > https://issues.apache.org/jira/browse/SQOOP-2349 > > > Repository: sqoop-trunk > > > Description > ------- > > I've introduced a cmd line parameter for being able to set the metadata > transaction levels (defined on java.sql.Connection) manually if necessary. > The change is backward compatible, so by default SQOOP gonna still use > READ_COMMITTED. > > > Diffs > ----- > > src/java/org/apache/sqoop/SqoopOptions.java e14a0b7 > src/java/org/apache/sqoop/manager/SqlManager.java 768507b > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 13a9697 > > Diff: https://reviews.apache.org/r/53423/diff/ > > > Testing > ------- > > > Thanks, > > Attila Szabo > >
