----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54030/#review157251 -----------------------------------------------------------
src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java (line 22) <https://reviews.apache.org/r/54030/#comment227778> I think it would be better to use org.apache.commons.lang.StringUtils for example, jodd.util seems to be a weird package for me. Hi Anna, Thank you for fixing the test cases, I have just minor comment to your patch. - Szabolcs Vasas On Nov. 29, 2016, 12:44 p.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54030/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 12:44 p.m.) > > > Review request for Sqoop, Attila Szabo and Szabolcs Vasas. > > > Bugs: SQOOP-3055 > https://issues.apache.org/jira/browse/SQOOP-3055 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-3055 MySQL tests are ignoring specified username, password and dbname, > trying to connect to specified db using currentuser (using > System.getEnv("USER") or whoami). You should now be able to specify the user > (and will have to when running Mysql tests), password, hostname and database > name for the MSQL tests (and they won't ignore it and use current users > anymore). > > > Diffs > ----- > > build.xml 6e8d393 > src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 79e90e2 > src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java d0f0c50 > src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 86b9aab > src/test/com/cloudera/sqoop/manager/MySQLAllTablesTest.java bad3c29 > src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 675b6b8 > src/test/com/cloudera/sqoop/manager/MySQLFreeFormQueryTest.java 935d948 > src/test/com/cloudera/sqoop/manager/MySQLLobAvroImportTest.java df78142 > src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java 0af79d6 > src/test/org/apache/sqoop/manager/mysql/MySqlCallExportTest.java 6bf939b > src/test/org/apache/sqoop/manager/mysql/MySqlColumnEscapeImportTest.java > 87cd389 > > Diff: https://reviews.apache.org/r/54030/diff/ > > > Testing > ------- > > Ran all MySQL tests with hadoopversion 260 and hbaseprofile 95: ant test > -Dhadoopversion=260 -Dhbaseprofile=95 -Dthirdparty=true > -Dsqoop.thirdparty.lib.dir=3rdpartylibdir > -Dsqoop.test.mysql.connectstring.host_url=mysqlhost > -Dsqoop.test.mysql.databasename=sqoop_repo -Dsqoop.test.mysql.password=sqoop > -Dsqoop.test.mysql.username=sqoop > > > Thanks, > > Anna Szonyi > >
