----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54427/ -----------------------------------------------------------
(Updated Dec. 6, 2016, 4:14 p.m.) Review request for Sqoop, Abraham Fine, Boglarka Egyed, Anna Szonyi, Szabolcs Vasas, and Erzsebet Szilagyi. Changes ------- Default fallback scenario (GMT) has been improved Bugs: SQOOP-3071 https://issues.apache.org/jira/browse/SQOOP-3071 Repository: sqoop-trunk Description ------- In the current implementation OraOop and OracleManager are different from the POV of setting sessionTimeZone in oracle. OracleManager does not set the TimeZone in java, and neither the default timeZone on the Oracle connection. Thus when the local timezone realted data is retrieved by Sqoop as not a String object, but as a Date, the timeZone information is lost, and this could cause confusion/bogus behaviour on user side. The goal is to get inline the two implementation. Diffs (updated) ----- src/java/org/apache/sqoop/manager/OracleManager.java 3273435e Diff: https://reviews.apache.org/r/54427/diff/ Testing ------- OracleManagerTest#testOracleImport now executes successfully in all circumstances Thanks, Attila Szabo